Remove Holly Worthen from 311 leadership page #8231
Conversation
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Availability: Mon-Fri after 6pm PST; Sat & Sun after 3PM PST. |
|
@FatCatLikesBeer Apologies but this is my first creating a pull request for hack4LA, are those the times that you can meet to review the pull request? If so, I can also meet tonight after 6pm |
|
Hi @edwarddim thanks for reaching out. We don't typically meet for pull reviews. Communication on issues, or feedback happen here in the comments section. The times are to let you and others know when I'm available to review your PR, and when to expect the feedback of my review. |
There was a problem hiding this comment.
Hello @edwarddim, thank you for taking on this issue!
Things Done Well
- Pull request is done with the correct branch
- Branch is properly named
- Issue is linked and understandable
- Appropriate changes made in the
Files changedtab - Before and after screen shots are included 👍🏽
- Website is still functional
- No spelling errors detected
Required Changes
- Check for CodeQL alerts and select the appropriate checkbox in your post
- Resolve merge conflict
When pulling your branch into my local fork, I was greeted with the following warning:
and when running a local instance of your branch, I don't see your changes:
My intuition is that since the file you edited,311-data.md, also has edits in commits ahead of yours, git is prioritizing the upstream changes instead of yours. Check out CONTRIBUTING.md, sections 2.7.d - 2.7.e or sections 3.1.c - 3.1.d for info on resolving this issue.
Once you made your changes, please reach out to me. I've updated my availability so I can approve your PR as soon as possible. Thank you for your hard work!
github-project-automation
bot
moved this from PR Needs review
to PRs being reviewed
in P: HfLA Website: Project Board
…update-project-profile-8015
…rddim/website into update-project-profile-8015
|
@FatCatLikesBeer Thank you for clarifying the pull request review, I really appreciate it! Also, just pulled the upstream branch and I think I am now ahead of gh-pages. I hope I've done it correctly. |
FatCatLikesBeer
left a comment
FatCatLikesBeer
left a comment
There was a problem hiding this comment.
@edwarddim Wow, what quick turn around time! Sorry for not getting back to you sooner!
Looks like you handled all the requested changes, thank you so much for your hard work!
I approve this PR!
|
Review ETA: 4 PM 7/3/25 Apologies for being the bottleneck! |
There was a problem hiding this comment.
👀 Visual Review
I’ve manually tested the frontend changes in the browser across multiple viewports:
- Do the changes address the issue? → Yes
- Are there unrelated changes? → No
- Do the changes negatively impact usability? → No
- Do links and components still work as expected? → Yes
💻 Code Review
I’ve reviewed the code changes:
- Could the code be further simplified? → No
- Are there areas that need additional comments or clarification? → No
- Are there any unrelated or drastic changes? → No
- Are any expected changes missing? → No
👍 Things done well
- Branch name includes the issue number and is descriptive
- PR references the related issue
- Includes screenshots
- Code is scoped and directly addresses the issue
I approve this PR. Thank you for contributing!
github-project-automation
bot
moved this from PRs being reviewed
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
|
Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉 |
|
Hey @edwarddim @FatCatLikesBeer @eunicode If you need help with PR reviews, pulling branches, or anything else, feel free to Slack message me or the other Merge Team members and Dev Co-Leads. Thanks. |
4 participants
Fixes #8015
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Visuals before changes are applied
Visuals after changes are applied